-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rvs/front power restrictions v2 #7824
Conversation
1dc7dec
to
de1e59c
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7824 +/- ##
============================================
- Coverage 28.22% 28.11% -0.11%
Complexity 2075 2075
============================================
Files 1276 1285 +9
Lines 156311 157442 +1131
Branches 3084 3117 +33
============================================
+ Hits 44115 44269 +154
- Misses 110355 111300 +945
- Partials 1841 1873 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3d839bc
to
2cf5596
Compare
front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/v2/ManageTrainScheduleV2.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/v2/ManageTrainScheduleV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, just a quick check on the code for forgot code comments mostly.
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/components/Pathfinding/PathfindingV2.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/v2/ManageTrainScheduleV2.tsx
Outdated
Show resolved
Hide resolved
3b4edbf
to
c5e8007
Compare
9abcaa4
to
56e7f56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review 🥳
56e7f56
to
d04ed93
Compare
d04ed93
to
1440239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, bravo for this huge PR, LGTM 💪
left a few comments about typo
front/src/modules/pathfinding/helpers/__tests__/getPathVoltages.spec.ts
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/helpers/__tests__/getPathVoltages.spec.ts
Outdated
Show resolved
Hide resolved
front/src/modules/pathfinding/helpers/__tests__/getPathVoltages.spec.ts
Outdated
Show resolved
Hide resolved
1440239
to
92c4baa
Compare
b5425ae
to
d4a0773
Compare
closes #7025
What does the power restriction selector do :
The user can :
Once a power restriction has been selected on an interval :